iOS support work in progress

iOS support work in progress

include/core/SkTypes.h
- address unsigned warning

include/core/SkInstCnt.h
src/core/SkInstCnt.cpp
gyp/common.gypi
- always define SK_ENABLE_INST_COUNT for debug builds

src/views/mac/SkNSView.mm
- only call glClear if there is a GL context

src/ports/SkImageDecoder_CG.cpp
- fix iOS hack by using proper include

gyp/opts.gyp
- exclude more ARM files from iOS for now (see issue 900)

gyp/common_conditions.gypi
- add release, more ios specific common settings

gyp/bench.gyp
- add iOS condition

gyp/SampleApp.gyp
- remove precompiled header, hardcoded SDK path
- add more frameworks

gyp/debugger.gyp
- fix syntax error
- add iOS/Android condition

gyp/core.gyp
- remove hardcoded SDK path, add more frameworks

gyp/common_variables.gypi
- add ios SDK path
- add ios SDK version

gyp/iOSSampleApp.gyp
- remove obsolete project

gyp/zlib.gyp
- add ios library path
Committed: https://code.google.com/p/skia/source/detail?r=5649

[bsalomon, 2012-09-24 14:25:13]

LGTM w/ minor question about inst count #if.

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
Just curious, how did this come up in the iOS build?

Should we make this header (or the SkConfig headers) automatically define
SK_ENABLE_INST_COUNT if SK_DEBUG is defined so that we don't have to repeat this
|| in multiple places?

[EricB, 2012-09-24 14:28:18]

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
On 2012/09/24 14:25:13, bsalomon wrote:
> Just curious, how did this come up in the iOS build?
> 
> Should we make this header (or the SkConfig headers) automatically define
> SK_ENABLE_INST_COUNT if SK_DEBUG is defined so that we don't have to repeat
this
> || in multiple places?

I don't see SK_ENABLE_INST_COUNT defined anywhere except in common.gypi.  If
we're removing that definition, then we should automatically define it or just
use SK_DEBUG instead.

[robertphillips, 2012-09-24 14:47:36]

LGMT modulo question r.e. SK_ENABLE_INST_COUNT.

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
What about defining SK_ENABLE_INST_COUNT to 0 if it isn't defined and then
converting all the tests to be #if rather than #ifdef?

[caryclark1, 2012-09-24 18:32:06]

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
On 2012/09/24 14:25:13, bsalomon wrote:
> Just curious, how did this come up in the iOS build?
The gyp-generated project doesn't work, so I created a hand-built project for
iOS to debug. The hand-built project didn't have SK_ENABLE_INST_COUNT even
though it was defined for the subprojects like core, so the object sizes did not
match.

> 
> Should we make this header (or the SkConfig headers) automatically define
> SK_ENABLE_INST_COUNT if SK_DEBUG is defined so that we don't have to repeat
this
> || in multiple places?
Done

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
The purpose of SK_ENABLE_INST_COUNT as a separate define is to allow enabling a
separate level of debugging in a release build. For robustness, it would make
sense to have yet another build flavor that enables this in release, although
that may be testing overkill.

On 2012/09/24 14:28:18, EricB wrote:
> On 2012/09/24 14:25:13, bsalomon wrote:
> > Just curious, how did this come up in the iOS build?
> > 
> > Should we make this header (or the SkConfig headers) automatically define
> > SK_ENABLE_INST_COUNT if SK_DEBUG is defined so that we don't have to repeat
> this
> > || in multiple places?
> 
> I don't see SK_ENABLE_INST_COUNT defined anywhere except in common.gypi.  If
> we're removing that definition, then we should automatically define it or just
> use SK_DEBUG instead.

https://codereview.appspot.com/6551070/diff/1/include/core/SkInstCnt.h#newcode21
include/core/SkInstCnt.h:21: #if defined SK_DEBUG || defined
SK_ENABLE_INST_COUNT
That would work, but it may be confusing since nearly all Skia defines are
tested by existence rather than by value. Take a look at the result of Brian's
suggestion to see if that is satisfactory.

On 2012/09/24 14:47:36, robertphillips wrote:
> What about defining SK_ENABLE_INST_COUNT to 0 if it isn't defined and then
> converting all the tests to be #if rather than #ifdef?

[EricB, 2012-09-24 18:40:32]

GYP changes LGTM at patch set 3.

[bsalomon, 2012-09-24 18:45:57]

LGTM

[robertphillips, 2012-09-24 19:31:39]

LGTM