Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 6550050: Adding hasRecorded API method to SkDeferredCanvas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by junov1
Modified:
11 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding hasPendingCommands API method to SkDeferredCanvas BUG=http://code.google.com/p/chromium/issues/detail?id=146178 Committed: https://code.google.com/p/skia/source/detail?r=5632

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M include/utils/SkDeferredCanvas.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 5 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6
junov1
PTAL
11 years, 11 months ago (2012-09-20 22:00:32 UTC) #1
Stephen White
https://codereview.appspot.com/6550050/diff/1/include/utils/SkDeferredCanvas.h File include/utils/SkDeferredCanvas.h (right): https://codereview.appspot.com/6550050/diff/1/include/utils/SkDeferredCanvas.h#newcode93 include/utils/SkDeferredCanvas.h:93: bool hasRecorded() const; bikeshed: maybe hasRecordedCommands()?
11 years, 11 months ago (2012-09-20 22:02:56 UTC) #2
junov1
Patch!
11 years, 11 months ago (2012-09-20 22:08:21 UTC) #3
Stephen White
LGTM
11 years, 11 months ago (2012-09-20 22:09:20 UTC) #4
reed1
Who is the caller of the new api?
11 years, 11 months ago (2012-09-21 12:27:13 UTC) #5
junov1
11 years, 11 months ago (2012-09-24 15:35:11 UTC) #6
Caller is WebKit, Canvas2DLayerBridge.cpp (CL in the works)
The method will be used to determine whether a block of JS code has added
pending commands to the canvas.  In conjunction with the isFreshFrame
method and the NotificationClient API, this will allow us to detect stale
canvases (canvases with two frames worth of deferral backlog).  This is so
we can replace the rate limiter (which does not work with the threaded
compositor) with a new mechanism that flushes deferred canvases when they
get stale.  This will effectively rate limit pages with canvases that do
not trigger the skip-on-clear optimization.  The end result is a quantum
leap in canvas animation smoothness, and it slightly improves frame rates
of non-RAF animations, with the threaded compositor enabled.

On Fri, Sep 21, 2012 at 8:27 AM, <reed@google.com> wrote:

> Who is the caller of the new api?
>
>
https://codereview.appspot.**com/6550050/<https://codereview.appspot.com/6550...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b