Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1084)

Issue 6548044: Make flattenables no longer depend on global static initializers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Leon
Modified:
12 years, 2 months ago
Reviewers:
bsalomon, DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make flattenables no longer depend on global static initializers. Instead, force all builds to call InitializeFlattenables. Remove the make_debugger script, which was created to force rebuilding without global static initializers so that all flattenables would be linked. It is no longer necessary since all flattenables will be linked thanks to InitializeFlattenables, which now can (and must) be called when global static initializers are turned on. BUG=https://code.google.com/p/skia/issues/detail?id=903 BUG=https://code.google.com/p/skia/issues/detail?id=902 Committed: https://code.google.com/p/skia/source/detail?r=5642

Patch Set 1 #

Patch Set 2 : Leave global static initializers as an option for a GPU test. #

Patch Set 3 : Remove the script to build the debugger with static initializers turned off. #

Patch Set 4 : Leave SkPostConfig unchanged. #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -157 lines) Patch
D debugger/make_debugger.sh View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M include/core/SkFlattenable.h View 3 chunks +0 lines, -20 lines 0 comments Download
M src/core/SkAnnotation.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkColorTable.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkComposeShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkData.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/core/SkFlattenable.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPathEffect.cpp View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkRectShape.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkSingleInputImageFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkStippleMaskFilter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkTransparentShader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/image/SkDataPixelRef.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/images/SkFlipPixelRef.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/images/SkImageRef_GlobalPool.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/ports/SkImageRef_ashmem.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils/SkUnitMappers.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/GLProgramsTest.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Leon
12 years, 2 months ago (2012-09-21 16:13:18 UTC) #1
DerekS
shouldn't there be some changes to the gyp files and SkPostConfig.h as we no longer ...
12 years, 2 months ago (2012-09-21 16:34:38 UTC) #2
Leon
> shouldn't there be some changes to the gyp files and SkPostConfig.h as we > ...
12 years, 2 months ago (2012-09-21 16:42:57 UTC) #3
DerekS
12 years, 2 months ago (2012-09-21 17:38:40 UTC) #4
lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b