Issue 6546055: state: allow watching non-existent node

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6546055: state: allow watching non-existent node

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by aram

Modified:
11 years, 7 months ago

Reviewers:
niemeyer, mp+125776

Visibility:
Public.

Description

state: allow watching non-existent node https://code.launchpad.net/~aramh/juju-core/91-state-watchers-confignodes-nonexistent/+merge/125776 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/watcher.go	View		1 chunk	+4 lines, -3 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

niemeyer

11 years, 7 months ago (2012-09-21 17:23:01 UTC) #2

https://codereview.appspot.com/6546055/diff/1/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/6546055/diff/1/state/watcher.go#newcode1004
state/watcher.go:1004: var revno int64 = -1
Test case?

https://codereview.appspot.com/6546055/diff/1/state/watcher.go#newcode1006
state/watcher.go:1006: if err == nil {
And if it's not?

Expand All Messages | Collapse All Messages