Issue 6546048: remove use of SkRefPtr in public header (SkPDFDocument.h)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6546048: remove use of SkRefPtr in public header (SkPDFDocument.h) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by reed1

Modified:
12 years, 2 months ago

Reviewers:
bungeman, Steve VanDeBogart, edisonn

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

remove use of SkRefPtr in public header (SkPDFDocument.h) Committed: https://code.google.com/p/skia/source/detail?r=5612

Patch Set 1 #

Total comments: 4

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	include/pdf/SkPDFDocument.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/pdf/SkPDFDocument.cpp	View		4 chunks	+10 lines, -8 lines	4 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

edisonn

LGTM https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp File src/pdf/SkPDFDocument.cpp (right): https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp#newcode60 src/pdf/SkPDFDocument.cpp:60: fSecondPageFirstResourceIndex(0) { minor consistency: ", fTrailerDict(NULL)"

12 years, 2 months ago (2012-09-20 16:03:38 UTC) #2

reed1

http://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp File src/pdf/SkPDFDocument.cpp (right): http://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp#newcode60 src/pdf/SkPDFDocument.cpp:60: fSecondPageFirstResourceIndex(0) { On 2012/09/20 16:03:38, edisonn wrote: > minor ...

12 years, 2 months ago (2012-09-20 17:54:09 UTC) #3

Steve VanDeBogart

LGTM https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp File src/pdf/SkPDFDocument.cpp (right): https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp#newcode270 src/pdf/SkPDFDocument.cpp:270: fTrailerDict->insert("Root", nit: will fit on one line now.

12 years, 2 months ago (2012-09-20 18:16:14 UTC) #4

reed1

12 years, 2 months ago (2012-09-20 18:19:10 UTC) #5

https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

https://codereview.appspot.com/6546048/diff/1/src/pdf/SkPDFDocument.cpp#newco...
src/pdf/SkPDFDocument.cpp:270: fTrailerDict->insert("Root",
On 2012/09/20 18:16:15, Steve VanDeBogart wrote:
> nit: will fit on one line now.

Done.

Expand All Messages | Collapse All Messages