Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 6545052: code review 6545052: codereview.py: Fix crash on auth error handling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by luriel
Modified:
10 years, 1 month ago
Reviewers:
adg
CC:
golang-dev, adg
Visibility:
Public.

Description

codereview.py: Fix crash on auth error handling. In recent Python versions .reason is a read-only property that simply gives you the msg value. Fixes issue 4024

Patch Set 1 #

Patch Set 2 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 90c9121e26c3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M lib/codereview/codereview.py View 1 2 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 4
luriel
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 2 months ago (2012-09-21 11:42:51 UTC) #1
luriel
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-09-22 05:46:36 UTC) #2
adg
LGTM
10 years, 2 months ago (2012-10-10 02:13:59 UTC) #3
minux1
10 years, 1 month ago (2012-10-10 16:24:09 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=26a110c84106 ***

codereview.py: Fix crash on auth error handling.

In recent Python versions .reason is a read-only property that simply gives you
the msg value.

Fixes issue 4024

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6545052

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b