Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1387)

Unified Diff: test/fixedbugs/bug444.go

Issue 6542058: code review 6542058: cmd/gc: fix use of nil interface, slice (Closed)
Patch Set: diff -r 5a92a8a1509d https://code.google.com/p/go/ Created 12 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cmd/8g/gsubr.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/fixedbugs/bug444.go
===================================================================
--- a/test/fixedbugs/bug444.go
+++ b/test/fixedbugs/bug444.go
@@ -6,6 +6,7 @@
// The no-op conversion here used to confuse the compiler
// into doing a load-effective-address of nil.
+// See issue 3670.
package main
@@ -13,7 +14,23 @@
type T interface {}
+var x bool
+
func main() {
reflect.TypeOf(nil)
- reflect.TypeOf(T(nil)) // used to fail
+ reflect.TypeOf(T(nil)) // used to miscompile
+ shouldPanic()
}
+
+func f() byte {
+ return []byte(nil)[0] // used to miscompile
+}
+
+func shouldPanic() {
+ defer func() {
+ if recover() == nil {
+ panic("not panicking")
+ }
+ }()
+ f()
+}
« no previous file with comments | « src/cmd/8g/gsubr.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b