Issue 6542049: remove all SkRefPtr from SkPDFDevice.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6542049: remove all SkRefPtr from SkPDFDevice.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by reed1

Modified:
12 years ago

Reviewers:
bungeman, Steve VanDeBogart, edisonn

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

remove all SkRefPtr from SkPDFDevice.h Committed: https://code.google.com/p/skia/source/detail?r=5609

Patch Set 1 #

Total comments: 2

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		12 chunks	+21 lines, -22 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

LGTM with question https://codereview.appspot.com/6542049/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.appspot.com/6542049/diff/1/src/pdf/SkPDFDevice.cpp#newcode1247 src/pdf/SkPDFDevice.cpp:1247: drawFormXObjectWithClip(curContent, clipStack, clipRegion, true); I'm being ...

12 years ago (2012-09-20 18:07:46 UTC) #3

reed1

12 years ago (2012-09-20 18:14:20 UTC) #4

https://codereview.appspot.com/6542049/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.appspot.com/6542049/diff/1/src/pdf/SkPDFDevice.cpp#newcode...
src/pdf/SkPDFDevice.cpp:1247: drawFormXObjectWithClip(curContent, clipStack,
clipRegion, true);
On 2012/09/20 18:07:46, Steve VanDeBogart wrote:
> I'm being dense, why do we not need get() here?

SkAutoTUnref has operators for * and ->

Expand All Messages | Collapse All Messages