In render_pictures tiled rendering, draw a separate PNG for each tile.

In render_pictures tiled rendering, draw a separate PNG for each tile.

Since the passed in picture may represent an image which is too large
to be represented on the GPU, never create such a large canvas. Instead,
after drawing to each tile, create a file showing just that tile.

Committed: https://code.google.com/p/skia/source/detail?r=5603

[EricB, 2012-09-20 11:56:26]

LGTM

[tfarina1, 2012-09-20 15:47:48]

https://codereview.appspot.com/6532056/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6532056/diff/1/tools/PictureRenderer.cpp#newco...
tools/PictureRenderer.cpp:102: bool PictureRenderer::write(SkCanvas* canvas,
SkString path) const {
should we pass |path| by const-ref?

[Leon, 2012-09-20 15:56:20]

https://codereview.appspot.com/6532056/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6532056/diff/1/tools/PictureRenderer.cpp#newco...
tools/PictureRenderer.cpp:102: bool PictureRenderer::write(SkCanvas* canvas,
SkString path) const {
On 2012/09/20 15:47:48, tfarina1 wrote:
> should we pass |path| by const-ref?

We could, but if you look down below, you'll see that I actually modify it. In
that case I would need to make the copy manually.