Issue 6531047: Skip empty directories and input files not ending in .skp in *_pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6531047: Skip empty directories and input files not ending in .skp in *_pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by EricB

Modified:
11 years, 9 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Skip empty directories and input files not ending in .skp in *_pictures Addressing https://code.google.com/p/skia/issues/detail?id=886 Committed: https://code.google.com/p/skia/source/detail?r=5597

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	tools/bench_pictures_main.cpp	View		1 chunk	+9 lines, -3 lines	0 comments	Download
	M	tools/render_pictures_main.cpp	View		1 chunk	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2012/09/19 14:02:38, EricB wrote:

lgtm

Expand All Messages | Collapse All Messages