Issue 6528044: code review 6528044: cmd/6g: cosmetic improvements to regopt debugging.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6528044: code review 6528044: cmd/6g: cosmetic improvements to regopt debugging. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by remyoudompheng

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/6g: cosmetic improvements to regopt debugging.

Patch Set 2 : diff -r b7ce1e467a60 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7ce1e467a60 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 63f7abcae015 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 63f7abcae015 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/cmd/6g/reg.c	View	1 2 3	3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-09-18 10:58:16 UTC) #1

rsc

LGTM http://codereview.appspot.com/6528044/diff/3002/src/cmd/6g/reg.c File src/cmd/6g/reg.c (right): http://codereview.appspot.com/6528044/diff/3002/src/cmd/6g/reg.c#newcode761 src/cmd/6g/reg.c:761: Var *v = var + rgp->varno; I know ...

12 years, 8 months ago (2012-09-18 15:20:50 UTC) #2

remyoudompheng

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 8 months ago (2012-09-21 18:15:07 UTC) #3

remyoudompheng

12 years, 8 months ago (2012-09-21 18:20:32 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=0e40a2e5fb61 ***

cmd/6g: cosmetic improvements to regopt debugging.

R=rsc, golang-dev
CC=golang-dev
http://codereview.appspot.com/6528044

http://codereview.appspot.com/6528044/diff/3002/src/cmd/6g/reg.c
File src/cmd/6g/reg.c (right):

http://codereview.appspot.com/6528044/diff/3002/src/cmd/6g/reg.c#newcode761
src/cmd/6g/reg.c:761: Var *v = var + rgp->varno;
On 2012/09/18 15:20:50, rsc wrote:
> I know it's annoying but please split this:
> 
> Var *v;
> 
> v = var + rgp->varno;

Done.

Expand All Messages | Collapse All Messages