Reuse one canvas for every tile in bench_pictures (in single threaded mode).

Reuse one canvas for every tile in bench_pictures (in single threaded mode).

Turn off multi threaded option for now.

In bench_pictures, do not create a large canvas, since we never use it.

Remove unused functions on TiledPictureRenderer.

Committed: https://code.google.com/p/skia/source/detail?r=5583

[Leon, 2012-09-14 21:14:34]

This will use only one tile for tiled drawing in bench_pictures.

render_pictures will still create the large canvas to copy each tile to.

[bsalomon, 2012-09-14 21:17:12]

On 2012/09/14 21:14:34, scroggo-work wrote:
> This will use only one tile for tiled drawing in bench_pictures.
> 
> render_pictures will still create the large canvas to copy each tile to.

rubber stamp lgtm

[EricB, 2012-09-14 21:25:06]

LGTM with question/suggestion

https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp#newco...
tools/PictureRenderer.cpp:206: tile_y_start += height) {
Would this be more stable if we looped over indices and multiplied to get the
tile boundaries, rather than doing a bunch of floating-point adds?

[Leon, 2012-09-17 21:52:51]

https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp#newco...
tools/PictureRenderer.cpp:206: tile_y_start += height) {
On 2012/09/14 21:25:06, EricB wrote:
> Would this be more stable if we looped over indices and multiplied to get the
> tile boundaries, rather than doing a bunch of floating-point adds?

Now that I think about it, these numbers are actually integers, so I think it
makes the most sense to leave them as integers until I create the rectangle. In
this case, I think addition is fine.

If you think using multiplication here is still better - it might be a little
clearer, check out patch set 2.

[EricB, 2012-09-18 11:52:36]

On 2012/09/17 21:52:51, scroggo-work wrote:
> https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp
> File tools/PictureRenderer.cpp (right):
> 
>
https://codereview.appspot.com/6521043/diff/1/tools/PictureRenderer.cpp#newco...
> tools/PictureRenderer.cpp:206: tile_y_start += height) {
> On 2012/09/14 21:25:06, EricB wrote:
> > Would this be more stable if we looped over indices and multiplied to get
the
> > tile boundaries, rather than doing a bunch of floating-point adds?
> 
> Now that I think about it, these numbers are actually integers, so I think it
> makes the most sense to leave them as integers until I create the rectangle.
In
> this case, I think addition is fine.
> 
> If you think using multiplication here is still better - it might be a little
> clearer, check out patch set 2.

LGTM at patch set 3.