Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1679)

Issue 65090044: Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Xia Lu
Modified:
10 years, 8 months ago
Reviewers:
arnold.koroa
Visibility:
Public.

Description

Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit

Patch Set 1 #

Total comments: 5

Patch Set 2 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Total comments: 2

Patch Set 3 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Total comments: 1

Patch Set 4 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Total comments: 2

Patch Set 5 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -382 lines) Patch
M src/main/java/teammates/common/datatransfer/FeedbackNumericalScaleQuestionDetails.java View 1 2 3 4 5 chunks +16 lines, -5 lines 0 comments Download
M src/main/java/teammates/common/util/Const.java View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/main/resources/feedbackQuestionNumScaleEditFormTemplate.html View 1 2 3 4 1 chunk +13 lines, -13 lines 0 comments Download
M src/main/webapp/js/instructorFeedbackEdit.js View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/main/webapp/jsp/instructorFeedbackEdit.jsp View 1 2 3 4 1 chunk +14 lines, -14 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java View 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackAddSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditEmpty.html View 1 2 3 4 1 chunk +19 lines, -24 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditPublished.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html View 1 2 3 4 1 chunk +21 lines, -26 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html View 1 2 3 4 2 chunks +21 lines, -26 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionAddSuccess.html View 1 2 3 4 2 chunks +41 lines, -47 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionEditSuccess.html View 1 2 3 4 2 chunks +40 lines, -47 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html View 1 2 3 4 1 chunk +20 lines, -25 lines 0 comments Download
M upload.py View 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4
arnold.koroa
https://codereview.appspot.com/65090044/diff/1/src/main/java/teammates/common/util/Const.java File src/main/java/teammates/common/util/Const.java (right): https://codereview.appspot.com/65090044/diff/1/src/main/java/teammates/common/util/Const.java#newcode147 src/main/java/teammates/common/util/Const.java:147: public static final String FEEDBACK_SESSION_NUMSCALE_MAX = "Maximum value of ...
10 years, 8 months ago (2014-02-18 07:57:56 UTC) #1
arnold.koroa
https://codereview.appspot.com/65090044/diff/20001/src/main/java/teammates/common/util/Const.java File src/main/java/teammates/common/util/Const.java (right): https://codereview.appspot.com/65090044/diff/20001/src/main/java/teammates/common/util/Const.java#newcode150 src/main/java/teammates/common/util/Const.java:150: change the variable names to "FEEDBACK_QUESTION..." and put them ...
10 years, 8 months ago (2014-02-19 07:59:39 UTC) #2
arnold.koroa
https://codereview.appspot.com/65090044/diff/30001/src/main/java/teammates/common/util/Const.java File src/main/java/teammates/common/util/Const.java (right): https://codereview.appspot.com/65090044/diff/30001/src/main/java/teammates/common/util/Const.java#newcode173 src/main/java/teammates/common/util/Const.java:173: public static final String FEEDBACK_QUESTION_NUMSCALE_MIN_VALUE = "Minimum acceptable response ...
10 years, 8 months ago (2014-02-20 02:12:30 UTC) #3
arnold.koroa
10 years, 8 months ago (2014-02-21 02:28:53 UTC) #4
https://codereview.appspot.com/65090044/diff/40001/src/main/java/teammates/co...
File
src/main/java/teammates/common/datatransfer/FeedbackNumericalScaleQuestionDetails.java
(right):

https://codereview.appspot.com/65090044/diff/40001/src/main/java/teammates/co...
src/main/java/teammates/common/datatransfer/FeedbackNumericalScaleQuestionDetails.java:86:
"${Const.ParamsNames.FEEDBACK_QUESTION_NUMSCALE_TOOLTIP_STEP}",
Const.Tooltips.FEEDBACK_QUESTION_NUMSCALE_STEP);
Change "${Const.ParamsNames.FEEDBACK_QUESTION_NUMSCALE_TOOLTIP_*"
to "${Const.Tooltips.FEEDBACK_QUESTION_NUMSCALE_*"?

https://codereview.appspot.com/65090044/diff/40001/src/main/resources/feedbac...
File src/main/resources/feedbackQuestionNumScaleEditFormTemplate.html (right):

https://codereview.appspot.com/65090044/diff/40001/src/main/resources/feedbac...
src/main/resources/feedbackQuestionNumScaleEditFormTemplate.html:5: <td
onmouseover="ddrivetip('${Const.ParamsNames.FEEDBACK_QUESTION_NUMSCALE_TOOLTIP_MIN}')"
"${Const.Tooltips.FEEDBACK_QUESTION_NUMSCALE_MIN"?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b