Issue 6506086: Consolidate texture access functions, provide default GrTextureAccess

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506086: Consolidate texture access functions, provide default GrTextureAccess (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bsalomon

Modified:
12 years, 3 months ago

Reviewers:
robertphillips

CC:
TomH, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -110 lines)			Patch
M	src/gpu/effects/GrColorTableEffect.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View		1 chunk	+4 lines, -12 lines	1 comment	Download
M	src/gpu/gl/GrGLProgram.cpp	View		2 chunks	+23 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1 2	7 chunks	+8 lines, -47 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		3 chunks	+5 lines, -28 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3

bsalomon

The next step after this CL is to make all the GrCustomStage subclasses provide their ...

12 years, 3 months ago (2012-09-06 22:00:13 UTC) #1

Closed with r5428