Issue 6506080: CMake toolchain config for Android NDK.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506080: CMake toolchain config for Android NDK.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by eugenis

Modified:
12 years, 4 months ago

Reviewers:
samsonov, Evgeniy Stepanov

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 2 : . #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	A	cmake/platforms/Android.cmake	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

samsonov

https://codereview.appspot.com/6506080/diff/1/cmake/platforms/Android.cmake File cmake/platforms/Android.cmake (right): https://codereview.appspot.com/6506080/diff/1/cmake/platforms/Android.cmake#newcode3 cmake/platforms/Android.cmake:3: SET(CMAKE_CXX_COMPILER ${CMAKE_BINARY_DIR}/../bin/clang++) Could you please add a comment about ...

12 years, 4 months ago (2012-09-06 13:33:51 UTC) #1

Evgeniy Stepanov

12 years, 4 months ago (2012-09-10 09:25:17 UTC) #2

samsonov

12 years, 4 months ago (2012-09-10 11:10:41 UTC) #3

LGTM, but I think that chandlerc or other CMake build system authors should
comment on this.

Expand All Messages | Collapse All Messages