Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(827)

Issue 65058: Add a virtual function NotifyNewAggregate and call it from the function AggregateObject

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by faker.moatamri
Modified:
13 years, 1 month ago
Reviewers:
Tom Henderson
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change the Doxygen for NotifyNewAggregate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/core/object.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/object.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Tom Henderson
13 years, 1 month ago (2009-05-18 04:59:07 UTC) #1
http://codereview.appspot.com/65058/diff/1/3
File src/core/object.h (right):

http://codereview.appspot.com/65058/diff/1/3#newcode166
Line 166: */
This doxygen seems very Internet stack specific yet this is an ns3::Object
method.  I would suggest removing references to specific internet stack use
cases.  In particular, what guidance to other future subclasses of Object can
you give about whether they need to reimplement this function?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b