Issue 65058: Add a virtual function NotifyNewAggregate and call it from the function AggregateObject

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65058: Add a virtual function NotifyNewAggregate and call it from the function AggregateObject

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by faker.moatamri

Modified:
14 years, 4 months ago

Reviewers:
Tom Henderson

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change the Doxygen for NotifyNewAggregate #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/core/object.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/core/object.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Tom Henderson

14 years, 4 months ago (2009-05-18 04:59:07 UTC) #1

http://codereview.appspot.com/65058/diff/1/3
File src/core/object.h (right):

http://codereview.appspot.com/65058/diff/1/3#newcode166
Line 166: */
This doxygen seems very Internet stack specific yet this is an ns3::Object
method.  I would suggest removing references to specific internet stack use
cases.  In particular, what guidance to other future subclasses of Object can
you give about whether they need to reimplement this function?

Expand All Messages | Collapse All Messages