Issue 65050043: all: sort imports consistently

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65050043: all: sort imports consistently

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rog

Modified:
11 years, 1 month ago

Reviewers:
mp+206704, axw, fwereade

Visibility:
Public.

Description

all: sort imports consistently https://code.launchpad.net/~rogpeppe/juju-core/503-sort-imports/+merge/206704 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: sort imports consistently #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -18 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/deploy.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cmd/juju/plugin.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/signmetadata_test.go	View	2 chunks	+1 line, -1 line	0 comments	Download
M	cmd/supercommand.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	environs/storage/interfaces.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	provider/all/all.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/local/local_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	provider/openstack/live_test.go	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	replicaset/replicaset_test.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	state/apiserver/client/run.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/keymanager/keymanager_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/keymanager/testing/fakesshimport.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	state/apiserver/upgrader/suite_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	state/export_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/checkers/deepequal_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	upgrades/file_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	version/version_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	worker/peergrouper/desired.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	worker/peergrouper/desired_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	worker/uniter/jujuc/config-get.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

11 years, 1 month ago (2014-02-18 01:05:26 UTC) #3

On 2014/02/17 13:02:08, rog wrote:
> Please take a look.

Was this done mechanically? It would be good to have a linter that ensures
adherence before allowing push or merge.

Expand All Messages | Collapse All Messages