Issue 65043: Adds caja logo, firebug lite and feedback bar to the testbed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65043: Adds caja logo, firebug lite and feedback bar to the testbed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by Jasvir

Modified:
16 years, 8 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Trivial changes to the testbed: * adds a logo * moves the feedback bar to the top of the page * adds firebug lite for those platforms that don't have it Submitted @3482

Patch Set 1 #

Total comments: 2

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -120 lines)			Patch
M	build.xml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/com/google/caja/demos/applet/caja_logo_small.png	View	Binary file		0 comments	Download
M	src/com/google/caja/demos/applet/index.html	View	5 chunks	+34 lines, -118 lines	2 comments	Download
A	src/com/google/caja/demos/applet/testbed.css	View	1 chunk	+127 lines, -0 lines	0 comments	Download
M	src/com/google/caja/demos/applet/testbed.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ihab.awad

16 years, 11 months ago (2009-05-12 17:12:23 UTC) #2

LGTM; comments minor & optional.

http://codereview.appspot.com/65043/diff/1/5
File src/com/google/caja/demos/applet/index.html (right):

http://codereview.appspot.com/65043/diff/1/5#newcode151
Line 151: |
Indent contents of <span>

http://codereview.appspot.com/65043/diff/1/5#newcode257
Line 257: renderTemplate(document.getElementById('testbed-ui'), uiSuffix));
Needs to be continuation indented.

Expand All Messages | Collapse All Messages