Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(393)

Issue 65043: Adds caja logo, firebug lite and feedback bar to the testbed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by Jasvir
Modified:
16 years, 8 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Trivial changes to the testbed: * adds a logo * moves the feedback bar to the top of the page * adds firebug lite for those platforms that don't have it Submitted @3482

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -120 lines) Patch
M build.xml View 1 chunk +2 lines, -0 lines 0 comments Download
A src/com/google/caja/demos/applet/caja_logo_small.png View Binary file 0 comments Download
M src/com/google/caja/demos/applet/index.html View 5 chunks +34 lines, -118 lines 2 comments Download
A src/com/google/caja/demos/applet/testbed.css View 1 chunk +127 lines, -0 lines 0 comments Download
M src/com/google/caja/demos/applet/testbed.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Jasvir
16 years, 11 months ago (2009-05-11 22:13:58 UTC) #1
ihab.awad
16 years, 11 months ago (2009-05-12 17:12:23 UTC) #2
LGTM; comments minor & optional.

http://codereview.appspot.com/65043/diff/1/5
File src/com/google/caja/demos/applet/index.html (right):

http://codereview.appspot.com/65043/diff/1/5#newcode151
Line 151: |
Indent contents of <span>

http://codereview.appspot.com/65043/diff/1/5#newcode257
Line 257: renderTemplate(document.getElementById('testbed-ui'), uiSuffix));
Needs to be continuation indented.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b