Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(706)

Issue 6504045: To avoid running out of memory, we rescale very large pictures before we (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by reed1
Modified:
12 years, 3 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

To avoid running out of memory, we rescale very large pictures before we render them. Committed: https://code.google.com/p/skia/source/detail?r=5530

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M tools/render_pictures_main.cpp View 2 chunks +43 lines, -1 line 3 comments Download

Messages

Total messages: 4
reed1
12 years, 3 months ago (2012-09-13 17:32:50 UTC) #1
EricB
https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp#newcode137 tools/render_pictures_main.cpp:137: pic = new SkPicture; Do we need to delete ...
12 years, 3 months ago (2012-09-13 17:38:37 UTC) #2
reed1
https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp#newcode137 tools/render_pictures_main.cpp:137: pic = new SkPicture; On 2012/09/13 17:38:37, EricB wrote: ...
12 years, 3 months ago (2012-09-13 17:41:23 UTC) #3
EricB
12 years, 3 months ago (2012-09-13 17:42:36 UTC) #4
LGTM

https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:137: pic = new SkPicture;
On 2012/09/13 17:41:24, reed1 wrote:
> On 2012/09/13 17:38:37, EricB wrote:
> > Do we need to delete pic?
> 
> aur.reset(pic) handles deletion

Gotcha.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b