Issue 6504045: To avoid running out of memory, we rescale very large pictures before we

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6504045: To avoid running out of memory, we rescale very large pictures before we (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by reed1

Modified:
11 years, 9 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

To avoid running out of memory, we rescale very large pictures before we render them. Committed: https://code.google.com/p/skia/source/detail?r=5530

Patch Set 1 #

Total comments: 3

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
	M	tools/render_pictures_main.cpp	View		2 chunks	+43 lines, -1 line	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

EricB

https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp#newcode137 tools/render_pictures_main.cpp:137: pic = new SkPicture; Do we need to delete ...

11 years, 9 months ago (2012-09-13 17:38:37 UTC) #2

reed1

11 years, 9 months ago (2012-09-13 17:41:23 UTC) #3

EricB

11 years, 9 months ago (2012-09-13 17:42:36 UTC) #4

LGTM

https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6504045/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:137: pic = new SkPicture;
On 2012/09/13 17:41:24, reed1 wrote:
> On 2012/09/13 17:38:37, EricB wrote:
> > Do we need to delete pic?
> 
> aur.reset(pic) handles deletion

Gotcha.

Expand All Messages | Collapse All Messages