Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(855)

Issue 6503106: Make texteffects gm work through serialization and pipe. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Leon
Modified:
11 years, 9 months ago
Reviewers:
DerekS, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make texteffects gm work through serialization and pipe. Move Line2DPathEffect (now Sk_) into a separate header file so it can be shared and initialized. Switch to the shared version in SampleAll and SampleSlides. Remove the skip pipe flag from texteffects, since it can now be serialized. I have a separate change to turn serialization on by default at https://codereview.appspot.com/6498121/ Committed: https://code.google.com/p/skia/source/detail?r=5512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -160 lines) Patch
M gm/texteffects.cpp View 3 chunks +1 line, -61 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 1 chunk +22 lines, -0 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +1 line, -48 lines 0 comments Download
M samplecode/SampleSlides.cpp View 2 chunks +1 line, -49 lines 0 comments Download
M src/core/SkOrderedWriteBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
Leon
11 years, 9 months ago (2012-09-12 16:53:44 UTC) #1
reed1
Not against this, but those new effects are really just thrown together (a while ago). ...
11 years, 9 months ago (2012-09-12 18:14:49 UTC) #2
reed1
11 years, 9 months ago (2012-09-12 18:18:32 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b