Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This

Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
allows the client more control over the scaling. Because of virtual overrides
and wanting to keep the old call-sites up and running, this CL renames the
virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to
a non-virtual helper function.

The implementation is to use the float-rect for computing the matrix, but still
cons-up an integer rect for the purposes of subsetting the original bitmap. We
do this by calling float_src->roundOut(&int_src) so that we include all
(partially) covered src pixels.

No change needed on SkDevice, since that signature is explicitly passed the
computed matrix.
Committed: https://code.google.com/p/skia/source/detail?r=5578

[reed1, 2012-09-17 14:45:43]

key changes are SkCanvas.[h,cpp]
the bulk of the rest are just renamings

[Leon, 2012-09-17 15:20:34]

https://codereview.appspot.com/6501140/diff/1/debugger/SkDebugCanvas.h
File debugger/SkDebugCanvas.h (right):

https://codereview.appspot.com/6501140/diff/1/debugger/SkDebugCanvas.h#newcod...
debugger/SkDebugCanvas.h:196: virtual void onDrawBitmapRect(const SkBitmap&,
const SkRect* src,
Do you mean:
drawBitmapRectToRect?

https://codereview.appspot.com/6501140/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.appspot.com/6501140/diff/1/include/core/SkCanvas.h#newcode642
include/core/SkCanvas.h:642: @param src      specify the subset of the bitmap to
be drawn
No need to remove "Optional"

[reed1, 2012-09-17 16:18:32]

right on both counts. uploaded fixes.

[Leon, 2012-09-17 16:42:28]

On 2012/09/17 16:18:32, reed1 wrote:
> right on both counts. uploaded fixes.

lgtm

[bsalomon, 2012-09-17 17:08:25]

https://codereview.appspot.com/6501140/diff/1/debugger/SkDrawCommand.cpp
File debugger/SkDrawCommand.cpp (right):

https://codereview.appspot.com/6501140/diff/1/debugger/SkDrawCommand.cpp#newc...
debugger/SkDrawCommand.cpp:183: DrawBitmapRect::DrawBitmapRect(const SkBitmap&
bitmap, const SkRect* src,
Should this class be DrawBitmapRectToRect now?

[bsalomon, 2012-09-17 17:08:45]

New GM?

[reed1, 2012-09-17 17:30:24]

add new gm (for both versions)

[bsalomon, 2012-09-17 17:45:54]

On 2012/09/17 17:30:24, reed1 wrote:
> add new gm (for both versions)

lgtm