Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(734)

Issue 6501101: code review 6501101: cgo: process DWARF info even when debug data is used fo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by jsing
Modified:
9 years, 9 months ago
Reviewers:
CC:
golang-dev, albert.strasheim, dfc, rsc, minux1
Visibility:
Public.

Description

cgo: process DWARF info even when debug data is used for value Always process the DWARF info, even when the const value is determined using the debug data block. This ensures that the injected enum is removed and future loads of the same constant do not trigger inconsistent definitions. Add tests for issues 2470 and 4054. Fixes issue 4054.

Patch Set 1 #

Patch Set 2 : diff -r a76067712fe9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a76067712fe9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b0c749cc5654 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f6668796d52c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -4 lines) Patch
M misc/cgo/test/basic.go View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M misc/cgo/test/cgo_test.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue4054a.go View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A misc/cgo/test/issue4054b.go View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 10 months ago (2012-09-07 13:01:40 UTC) #1
albert.strasheim
Hello Maybe a test? There's been other stuff like this that also didn't spawn tests: ...
9 years, 10 months ago (2012-09-08 05:29:28 UTC) #2
dfc
This looks to have fixed the problem with cgo + enums. I agree a test ...
9 years, 10 months ago (2012-09-10 03:43:14 UTC) #3
rsc
Is it possible to add a test? See misc/cgo.
9 years, 9 months ago (2012-09-17 20:55:06 UTC) #4
jsing
On 2012/09/17 20:55:06, rsc wrote: > Is it possible to add a test? See misc/cgo. ...
9 years, 9 months ago (2012-09-18 15:44:35 UTC) #5
dfc
I can try to write up something tonight by adapting a piece of cgo code ...
9 years, 9 months ago (2012-09-18 15:45:42 UTC) #6
jsing
On 2012/09/17 20:55:06, rsc wrote: > Is it possible to add a test? See misc/cgo. ...
9 years, 9 months ago (2012-09-19 13:29:57 UTC) #7
dfc
On 2012/09/19 13:29:57, jsing wrote: > On 2012/09/17 20:55:06, rsc wrote: > > Is it ...
9 years, 9 months ago (2012-09-19 14:19:05 UTC) #8
dfc
Wait for fullung at least.
9 years, 9 months ago (2012-09-19 14:19:20 UTC) #9
albert.strasheim
LGTM
9 years, 9 months ago (2012-09-19 16:41:07 UTC) #10
minux1
LGTM.
9 years, 9 months ago (2012-09-19 17:01:32 UTC) #11
jsing
9 years, 9 months ago (2012-09-20 03:21:14 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=979c5e5b1308 ***

cgo: process DWARF info even when debug data is used for value

Always process the DWARF info, even when the const value is determined
using the debug data block. This ensures that the injected enum is
removed and future loads of the same constant do not trigger
inconsistent definitions.

Add tests for issues 2470 and 4054.
Fixes issue 4054.

R=golang-dev, fullung, dave, rsc, minux.ma
CC=golang-dev
http://codereview.appspot.com/6501101
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b