Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1965)

Issue 6501081: Added bench to test multiple readPixels case (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by robertphillips
Modified:
12 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I think this captures the SchemerDreamer use case: running bench [640 480] readpix 8888: cmsecs = 0.62 GPU: cmsecs = 103.74 gmsecs = 104.05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A bench/ReadPixBench.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 2 months ago (2012-09-04 13:18:31 UTC) #1
bsalomon
On 2012/09/04 13:18:31, robertphillips wrote: LGTM, should we have a variant that does a trivial ...
12 years, 2 months ago (2012-09-04 13:21:48 UTC) #2
robertphillips
12 years, 2 months ago (2012-09-04 13:41:40 UTC) #3
I actually already have a straw-man fix for this but I wanted to deliver it
separately so we would have before and after times. I don't know if we would get
any benefit from always benching the degenerate write-read-loop case.

committed as r5381
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b