Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(446)

Issue 6501057: code review 6501057: net: add test for Conn, PacketConn and Listener (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by mikio
Modified:
12 years, 8 months ago
Reviewers:
CC:
rsc, gobot, golang-dev
Visibility:
Public.

Description

net: add test for Conn, PacketConn and Listener I just realized that there is no good place for adding exposed function or method tests because server, unicast and multicast_test.go do test complicated multiple test objects, platform behaviros, protocol behaviors and API, at the same time. Perhaps splitting them into per test object might be better, so this CL provides tests focused on API.

Patch Set 1 : diff -r 3181682928c9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -0 lines) Patch
A src/pkg/net/conn_test.go View 1 chunk +103 lines, -0 lines 0 comments Download
A src/pkg/net/packetconn_test.go View 1 chunk +161 lines, -0 lines 0 comments Download
A src/pkg/net/protoconn_test.go View 1 chunk +185 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 10 months ago (2012-08-29 10:31:56 UTC) #1
gobot
R=rsc (assigned by rsc)
12 years, 10 months ago (2012-09-01 14:40:34 UTC) #2
rsc
LGTM Sorry this took so long.
12 years, 8 months ago (2012-10-21 21:17:46 UTC) #3
rsc
12 years, 8 months ago (2012-10-21 21:17:55 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=fced4ed97c25 ***

net: add test for Conn, PacketConn and Listener

I just realized that there is no good place for adding
exposed function or method tests because server, unicast
and multicast_test.go do test complicated multiple test
objects, platform behaviros, protocol behaviors and API,
at the same time. Perhaps splitting them into per test
object might be better, so this CL provides tests focused
on API.

R=rsc
CC=gobot, golang-dev
http://codereview.appspot.com/6501057

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b