Issue 6500133: AdSense Host API v4.1 samples

Issue 6500133: AdSense Host API v4.1 samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by sgomes_google

Modified:
12 years, 3 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Style changes, per jcgregorio's comments #

Total comments: 1

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1385 lines, -0 lines)			Patch
A	samples/adsensehost/README	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	samples/adsensehost/add_ad_unit_to_publisher.py	View	1	1 chunk	+94 lines, -0 lines	0 comments	Download
A	samples/adsensehost/add_custom_channel_to_host.py	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
A	samples/adsensehost/add_url_channel_to_host.py	View	1	1 chunk	+63 lines, -0 lines	1 comment	Download
A	samples/adsensehost/client_secrets.json	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	samples/adsensehost/delete_ad_unit_on_publisher.py	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
A	samples/adsensehost/delete_custom_channel_on_host.py	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
A	samples/adsensehost/delete_url_channel_on_host.py	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
A	samples/adsensehost/generate_report_for_host.py	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download
A	samples/adsensehost/generate_report_for_publisher.py	View	1	1 chunk	+83 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_account_data_for_existing_publisher.py	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_all_ad_clients_for_host.py	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_all_ad_clients_for_publisher.py	View	1	1 chunk	+73 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_all_ad_units_for_publisher.py	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_all_custom_channels_for_host.py	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
A	samples/adsensehost/get_all_url_channels_for_host.py	View	1	1 chunk	+70 lines, -0 lines	0 comments	Download
A	samples/adsensehost/sample_utils.py	View		1 chunk	+137 lines, -0 lines	0 comments	Download
A	samples/adsensehost/start_association_session.py	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	samples/adsensehost/update_ad_unit_on_publisher.py	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
A	samples/adsensehost/update_custom_channel_on_host.py	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
A	samples/adsensehost/verify_association_session.py	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jcgregorio_google

Check all the samples for the two style comments below. https://codereview.appspot.com/6500133/diff/1/samples/adsensehost/add_ad_unit_to_publisher.py File samples/adsensehost/add_ad_unit_to_publisher.py (right): https://codereview.appspot.com/6500133/diff/1/samples/adsensehost/add_ad_unit_to_publisher.py#newcode49 ...

12 years, 10 months ago (2012-09-27 18:30:39 UTC) #2

sgomes_google

https://codereview.appspot.com/6500133/diff/1/samples/adsensehost/add_ad_unit_to_publisher.py File samples/adsensehost/add_ad_unit_to_publisher.py (right): https://codereview.appspot.com/6500133/diff/1/samples/adsensehost/add_ad_unit_to_publisher.py#newcode49 samples/adsensehost/add_ad_unit_to_publisher.py:49: account_id = gflags.FLAGS.account_id On 2012/09/27 18:30:39, jcgregorio_google wrote: > ...

12 years, 10 months ago (2012-09-28 12:31:05 UTC) #3

jcgregorio_google

12 years, 10 months ago (2012-10-01 19:58:35 UTC) #4

https://codereview.appspot.com/6500133/diff/5001/samples/adsensehost/add_url_...
File samples/adsensehost/add_url_channel_to_host.py (right):

https://codereview.appspot.com/6500133/diff/5001/samples/adsensehost/add_url_...
samples/adsensehost/add_url_channel_to_host.py:47: 'urlPattern':
'www.example.com/%s' % sample_utils.get_unique_name()
The www.example.com seems odd here, should that be passed in via command-line
flag?

Expand All Messages | Collapse All Messages