Use double dashes for bench options to be consistent.

Use double dashes for bench options to be consistent.

Breaks the bots, since the arguments being passed to bench have changed, but there is a change to fix it at https://codereview.appspot.com/6488114/

Committed: https://code.google.com/p/skia/source/detail?r=5513

[EricB, 2012-09-11 20:00:47]

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode351
bench/benchmain.cpp:351: SkDebugf("Usage: bench [--o outDir] [--repeat nr]
[--logPerIter 1|0] "
I think the convention is '-' for single-letter arguments and '--' for multiple.
 This is how GM works.

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode438
bench/benchmain.cpp:438: if (strcmp(*argv, "--o") == 0) {
"-"

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode600
bench/benchmain.cpp:600: } else if (strlen(*argv) > 2 && strncmp(*argv, "--D",
2) == 0) {
"-"

[Leon, 2012-09-11 20:11:10]

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode351
bench/benchmain.cpp:351: SkDebugf("Usage: bench [--o outDir] [--repeat nr]
[--logPerIter 1|0] "
On 2012/09/11 20:00:47, EricB wrote:
> I think the convention is '-' for single-letter arguments and '--' for
multiple.
>  This is how GM works.

Done.

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode438
bench/benchmain.cpp:438: if (strcmp(*argv, "--o") == 0) {
On 2012/09/11 20:00:47, EricB wrote:
> "-"

Done.

https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode600
bench/benchmain.cpp:600: } else if (strlen(*argv) > 2 && strncmp(*argv, "--D",
2) == 0) {
On 2012/09/11 20:00:47, EricB wrote:
> "-"

Done.

[EricB, 2012-09-11 20:17:17]

On 2012/09/11 20:11:10, scroggo-work wrote:
> https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp
> File bench/benchmain.cpp (right):
> 
> https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode351
> bench/benchmain.cpp:351: SkDebugf("Usage: bench [--o outDir] [--repeat nr]
> [--logPerIter 1|0] "
> On 2012/09/11 20:00:47, EricB wrote:
> > I think the convention is '-' for single-letter arguments and '--' for
> multiple.
> >  This is how GM works.
> 
> Done.
> 
> https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode438
> bench/benchmain.cpp:438: if (strcmp(*argv, "--o") == 0) {
> On 2012/09/11 20:00:47, EricB wrote:
> > "-"
> 
> Done.
> 
> https://codereview.appspot.com/6500108/diff/1/bench/benchmain.cpp#newcode600
> bench/benchmain.cpp:600: } else if (strlen(*argv) > 2 && strncmp(*argv, "--D",
> 2) == 0) {
> On 2012/09/11 20:00:47, EricB wrote:
> > "-"
> 
> Done.

LGTM