In 4731 the line breaking in SkTextBox was changed to use public interfaces, but at ...
12 years, 3 months ago
(2012-09-05 16:03:34 UTC)
#1
In 4731 the line breaking in SkTextBox was changed to use public interfaces, but
at the same time lost a lot of functionality. This change restores the old
functionality plus handling for line ending characters and reporting ignored
trailing whitespace.
This is an alternative to http://codereview.appspot.com/6503064/ .
On 2012/09/05 16:03:34, bungeman wrote: It Seemed that I hadn't noticed the version before revision ...
12 years, 3 months ago
(2012-09-05 17:59:28 UTC)
#2
On 2012/09/05 16:03:34, bungeman wrote:
It Seemed that I hadn't noticed the version before revision 4731 had included
the functionality I reworked.
I like the way how it reporting ignored trailing whitespace.
On 2012/09/05 20:06:07, reed1 wrote: > seems fine. Do we have a record of why ...
12 years, 3 months ago
(2012-09-05 20:23:48 UTC)
#4
On 2012/09/05 20:06:07, reed1 wrote:
> seems fine. Do we have a record of why it was removed before? Do we want to
> write a test that exercises this (restored) behavior?
It was removed before because we were trying to make several .h files internal,
and SkTextBox was depending on them. At the time we didn't know of any real
users of SkTextBox, so the most expedient thing was done. Since someone seems to
have taken an interest, it seems like a good idea to finally get around to
restoring it.
Issue 6500078: Restore line breaking in SkTextBox.
(Closed)
Created 12 years, 3 months ago by bungeman
Modified 12 years, 3 months ago
Reviewers: Jare, reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0