Issue 6500045: Linux warning fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6500045: Linux warning fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Warning fixes

Patch Set 1 #

Patch Set 2 : remove trailing space #

Patch Set 3 : more #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	src/gpu/GrMemoryPool.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download
M	src/gpu/gl/GrGLSL.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

lgtm w/ suggestion about using 0 instead of mumble_cast<verbose>(NULL), but just a suggestion. https://codereview.appspot.com/6500045/diff/4001/src/gpu/GrMemoryPool.cpp File ...

12 years, 2 months ago (2012-08-29 17:45:44 UTC) #3

Committed as r5337 (w/ = 0 rather than bloated_cast)

Expand All Messages | Collapse All Messages