Issue 6499089: Fix Bug 1519

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499089: Fix Bug 1519 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by ihab.awad

Modified:
13 years, 2 months ago

Reviewers:
Jasvir, metaweta

CC:
caja-discuss-undisclosed_googlegroups.com, MarkM, felix8a, ihab.awad, Jasvir, kpreid2, MikeSamuel

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

http://code.google.com/p/google-caja/issues/detail?id=1519

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -4 lines)			Patch
M	src/com/google/caja/plugin/taming-membrane.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-taming-tamed.js	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-taming-tamed-guest.html	View		7 chunks	+35 lines, -2 lines	0 comments	Download

Total messages: 9

ihab.awad

Changed reviewer to metaweta@ since he's available at the moment.

13 years, 4 months ago (2012-09-07 19:45:49 UTC) #2

metaweta

lgtm Has anyone ever asked for the ability to assign to a method slot? We've ...

13 years, 4 months ago (2012-09-07 20:16:09 UTC) #4

ihab.awad

Thanks. No, not yet -- though this is coming up in some work we are ...

13 years, 4 months ago (2012-09-07 20:17:31 UTC) #5

metaweta

On 2012/09/07 23:01:39, Jasvir wrote: > LGTM please close

13 years, 3 months ago (2012-10-09 20:08:28 UTC) #7

metaweta

On 2012/10/09 20:08:28, metaweta wrote: > On 2012/09/07 23:01:39, Jasvir wrote: > > LGTM > ...

13 years, 2 months ago (2012-10-29 19:47:05 UTC) #8

ihab.awad

13 years, 2 months ago (2012-11-08 23:23:05 UTC) #9

Fixed in r5082

http://code.google.com/p/google-caja/source/detail?r=5082