Issue 6499083: CMake Android build rules for asan runtime and tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499083: CMake Android build rules for asan runtime and tests.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by eugenis

Modified:
12 years, 4 months ago

Reviewers:
samsonov, Evgeniy Stepanov

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/

Visibility:
Public.

Patch Set 3 : . #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -41 lines)			Patch
M	CMakeLists.txt	View	2	2 chunks	+7 lines, -14 lines	0 comments	Download
M	lib/asan/CMakeLists.txt	View	1 2	2 chunks	+18 lines, -8 lines	1 comment	Download
M	lib/asan/tests/CMakeLists.txt	View	1 2	4 chunks	+57 lines, -15 lines	1 comment	Download
M	lib/interception/CMakeLists.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/sanitizer_common/CMakeLists.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

samsonov

LGTM! https://codereview.appspot.com/6499083/diff/2001/lib/asan/tests/CMakeLists.txt File lib/asan/tests/CMakeLists.txt (right): https://codereview.appspot.com/6499083/diff/2001/lib/asan/tests/CMakeLists.txt#newcode147 lib/asan/tests/CMakeLists.txt:147: ${ASAN_UNITTEST_INSTRUMENTED_CFLAGS} ${ASAN_GTEST_INCLUDE_CFLAGS} Hm, can you use set_source_file_properties(${ASAN_NOINST_TEST_SOURCES} PROPERTIES ...

12 years, 4 months ago (2012-09-06 13:38:29 UTC) #1

Evgeniy Stepanov

PTAL. I've added custom CFLAGS for Android (there are significant differencies, like not using a ...

12 years, 4 months ago (2012-09-10 10:24:48 UTC) #2

samsonov

12 years, 4 months ago (2012-09-10 11:10:05 UTC) #3

LGTM

https://codereview.appspot.com/6499083/diff/6001/lib/asan/CMakeLists.txt
File lib/asan/CMakeLists.txt (right):

https://codereview.appspot.com/6499083/diff/6001/lib/asan/CMakeLists.txt#newc...
lib/asan/CMakeLists.txt:46: endif()
I think you may introduce ASAN_COMMON_DEFINITONS, ASAN_ANDROID_DEFINITIONS, but
leaving this up to you.

https://codereview.appspot.com/6499083/diff/6001/lib/asan/tests/CMakeLists.txt
File lib/asan/tests/CMakeLists.txt (right):

https://codereview.appspot.com/6499083/diff/6001/lib/asan/tests/CMakeLists.tx...
lib/asan/tests/CMakeLists.txt:17: if(ANDROID)
Same here. Could you please remove much of flags duplication here?

Expand All Messages | Collapse All Messages