Issue 6499052: Added find, lock to GrContext & GrResourceCache interfaces

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499052: Added find, lock to GrContext & GrResourceCache interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by robertphillips

Modified:
12 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Part of planned changes to texture cache interface. Yet to come: new createTexture & releaseTexture.

Patch Set 1 #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -2 lines)			Patch
M	include/gpu/GrContext.h	View	3 chunks	+12 lines, -0 lines	2 comments	Download
M	src/gpu/GrContext.cpp	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	3 chunks	+32 lines, -0 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	4 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6499052/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.appspot.com/6499052/diff/1/include/gpu/GrContext.h#newcode183 include/gpu/GrContext.h:183: * Make a texture un-purgeable in the cache Probably ...

12 years, 4 months ago (2012-08-29 19:46:04 UTC) #2

robertphillips

12 years, 4 months ago (2012-08-29 20:01:16 UTC) #3

bsalomon

On 2012/08/29 20:01:16, robertphillips wrote: > https://codereview.appspot.com/6499052/diff/1/include/gpu/GrContext.h > File include/gpu/GrContext.h (right): > > https://codereview.appspot.com/6499052/diff/1/include/gpu/GrContext.h#newcode183 > ...

12 years, 4 months ago (2012-08-29 20:03:00 UTC) #4

comitted as r5343

Expand All Messages | Collapse All Messages