Issue 6499044: Hide GrDrawTarget::Caps's member vars

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499044: Hide GrDrawTarget::Caps's member vars (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bsalomon

Modified:
12 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -84 lines)			Patch
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrBufferAllocPool.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View	3 chunks	+43 lines, -14 lines	2 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	4 chunks	+16 lines, -17 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrPathRendererChain.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrTexture.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	8 chunks	+29 lines, -27 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/GLProgramsTest.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 1 comment suggestion/correction https://codereview.appspot.com/6499044/diff/1/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.appspot.com/6499044/diff/1/src/gpu/GrDrawTarget.h#newcode29 src/gpu/GrDrawTarget.h:29: protected: It's not really ...

12 years, 3 months ago (2012-08-28 17:30:15 UTC) #2

bsalomon

12 years, 3 months ago (2012-08-28 21:11:46 UTC) #3

https://codereview.appspot.com/6499044/diff/1/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.appspot.com/6499044/diff/1/src/gpu/GrDrawTarget.h#newcode29
src/gpu/GrDrawTarget.h:29: protected:
On 2012/08/28 17:30:15, robertphillips wrote:
> It's not really a parent class.

Done.

Expand All Messages | Collapse All Messages