Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(508)

Issue 6498121: Turn serialization back on in GM. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Leon
Modified:
12 years, 3 months ago
Reviewers:
EricB, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Turn serialization back on in GM. With https://codereview.appspot.com/6503106/ it is now safe to do serialization by default. Committed: https://code.google.com/p/skia/source/detail?r=5551

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M gm/gmmain.cpp View 1 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7
Leon
12 years, 3 months ago (2012-09-12 16:50:18 UTC) #1
Leon
12 years, 3 months ago (2012-09-12 18:52:44 UTC) #2
Leon
12 years, 3 months ago (2012-09-12 18:53:01 UTC) #3
Leon
On 2012/09/12 18:53:01, scroggo-work wrote: Eric: Can we add --serialize to the bots, before my ...
12 years, 3 months ago (2012-09-12 19:12:29 UTC) #4
EricB
On 2012/09/12 19:12:29, scroggo-work wrote: > On 2012/09/12 18:53:01, scroggo-work wrote: > > Eric: Can ...
12 years, 3 months ago (2012-09-13 11:32:10 UTC) #5
Leon
On 2012/09/13 11:32:10, EricB wrote: > On 2012/09/12 19:12:29, scroggo-work wrote: > > On 2012/09/12 ...
12 years, 3 months ago (2012-09-13 15:22:53 UTC) #6
EricB
12 years, 3 months ago (2012-09-13 15:27:09 UTC) #7
On 2012/09/13 15:22:53, scroggo-work wrote:
> On 2012/09/13 11:32:10, EricB wrote:
> > On 2012/09/12 19:12:29, scroggo-work wrote:
> > > On 2012/09/12 18:53:01, scroggo-work wrote:
> > > 
> > > Eric: Can we add --serialize to the bots, before my change goes in, so
that
> we
> > > can make sure that it works before changing the default?
> > > 
> > > Mike also suggested we leave in the --serialize flag, so that a client
does
> > not
> > > get an error just because we changed the default.
> > 
> > I agree about leaving the --serialize flag.  As we discussed, I'm not sure
> what
> > we win by adding --serialize to the bots, since we'd get the same effect by
> just
> > committing this change.
> 
> Done.

I have a CL up to run the bots with --serialize (after discussion with Mike). 
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b