Add some more things that should be ignored to .gitignore

Add some more things that should be ignored to .gitignore

[tfarina1, 2012-09-12 15:44:15]

https://codereview.appspot.com/6498119/diff/1/.gitignore
File .gitignore (right):

https://codereview.appspot.com/6498119/diff/1/.gitignore#newcode3
.gitignore:3: gyp/build/
should this start with slash (/) as well? 

skhello.png should be probably added too.

how did you get gyp/build?

I guess I didn't because I do ninja build in out/Debug/Release.

[Leon, 2012-09-12 16:01:25]

On 2012/09/12 15:44:15, tfarina1 wrote:
> https://codereview.appspot.com/6498119/diff/1/.gitignore
> File .gitignore (right):
> 
> https://codereview.appspot.com/6498119/diff/1/.gitignore#newcode3
> .gitignore:3: gyp/build/
> should this start with slash (/) as well? 

Both will work in this case. If you think we should be consistent, I am fine
with adding the slash.
 
> 
> skhello.png should be probably added too.

Where does that come from? 
> 
> how did you get gyp/build?

By running .gyp_skia on a mac.
> 
> I guess I didn't because I do ninja build in out/Debug/Release.

[tfarina1, 2012-09-12 16:04:37]

On Wed, Sep 12, 2012 at 1:01 PM,  <scroggo@google.com> wrote:
> On 2012/09/12 15:44:15, tfarina1 wrote:
>>
>> https://codereview.appspot.com/6498119/diff/1/.gitignore
>> File .gitignore (right):
>
>
>> https://codereview.appspot.com/6498119/diff/1/.gitignore#newcode3
>> .gitignore:3: gyp/build/
>> should this start with slash (/) as well?
>
>
> Both will work in this case. If you think we should be consistent, I am
> fine with adding the slash.
>
Yup, please add. I think it's better to be consistent here. lgtm with
that. But my lgtm is only informal as I'm not a skia committer.

>
>
>> skhello.png should be probably added too.
>
>
> Where does that come from?
>
Ah, it comes from running ./out/Debug/skhello without -o argument.

>
>> how did you get gyp/build?
>
>
> By running .gyp_skia on a mac.
>
OK.


-- 
Thiago

[Leon, 2012-09-12 16:12:01]

Added.

[Leon, 2012-09-12 16:33:28]

Accidentally had this on my master branch, so I uploaded to
https://codereview.appspot.com/6503107/ and have submitted.