LGTM + 2 suggestions (feel free to ignore) https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp File src/gpu/SkGrFontScaler.cpp (right): https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp#newc... src/gpu/SkGrFontScaler.cpp:117: void expand_bits(INT_TYPE* dst, const uint8_t* src, int width, int height, int dstRB, int srcRB) { Expand RB to RowBytes? I didn't grok the abbreviation until the end of the method. https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp#newc... src/gpu/SkGrFontScaler.cpp:122: while (count > 0) { rename mask to curByte?
https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp File src/gpu/SkGrFontScaler.cpp (right): https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp#newc... src/gpu/SkGrFontScaler.cpp:124: for (int i = 7; i >= 0 && count; --i, --count) { alternate, that has no branch *d++ = ~((mask >> i) & 1);