Issue 6498105: Fix issue where bw bitmask uploaded to gr 565, 8888 glyph cache

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6498105: Fix issue where bw bitmask uploaded to gr 565, 8888 glyph cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
rileya, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -14 lines)			Patch
	M	src/gpu/SkGrFontScaler.cpp	View		2 chunks	+37 lines, -14 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 2 suggestions (feel free to ignore) https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp File src/gpu/SkGrFontScaler.cpp (right): https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp#newcode117 src/gpu/SkGrFontScaler.cpp:117: void ...

12 years, 2 months ago (2012-09-09 16:44:52 UTC) #2

reed1

12 years, 2 months ago (2012-09-10 13:37:04 UTC) #3

https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp
File src/gpu/SkGrFontScaler.cpp (right):

https://codereview.appspot.com/6498105/diff/1/src/gpu/SkGrFontScaler.cpp#newc...
src/gpu/SkGrFontScaler.cpp:124: for (int i = 7; i >= 0 && count; --i, --count) {
alternate, that has no branch

    *d++ = ~((mask >> i) & 1);

Expand All Messages | Collapse All Messages