Issue 6498046: Make the SkGrPixelRef be responsible for unlocking device's scratch texture in the cache

Issue 6498046: Make the SkGrPixelRef be responsible for unlocking device's scratch texture in the cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 4

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -18 lines)			Patch
M	include/gpu/SkGpuDevice.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	2 chunks	+7 lines, -1 line	2 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	5 chunks	+6 lines, -12 lines	2 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 2 comment suggestions https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h File include/gpu/SkGrPixelRef.h (right): https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h#newcode64 include/gpu/SkGrPixelRef.h:64: GrSurface* fSurface; Maybe a ...

12 years, 2 months ago (2012-08-28 15:02:31 UTC) #2

bsalomon

Closed with r5307. https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h File include/gpu/SkGrPixelRef.h (right): https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h#newcode64 include/gpu/SkGrPixelRef.h:64: GrSurface* fSurface; On 2012/08/28 15:02:31, robertphillips ...

12 years, 2 months ago (2012-08-28 15:08:50 UTC) #3

bsalomon

12 years, 2 months ago (2012-08-28 15:09:19 UTC) #4

On 2012/08/28 15:08:50, bsalomon wrote:
> Closed with r5307.


Make that r5313. 

> https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h
> File include/gpu/SkGrPixelRef.h (right):
> 
>
https://codereview.appspot.com/6498046/diff/1/include/gpu/SkGrPixelRef.h#newc...
> include/gpu/SkGrPixelRef.h:64: GrSurface*  fSurface;
> On 2012/08/28 15:02:31, robertphillips wrote:
> > Maybe a comment here like: "// if true, this pixel refs owns the lock on
> > 'fSurface'"?
> 
> Done.
> 
> https://codereview.appspot.com/6498046/diff/1/src/gpu/SkGpuDevice.cpp
> File src/gpu/SkGpuDevice.cpp (right):
> 
>
https://codereview.appspot.com/6498046/diff/1/src/gpu/SkGpuDevice.cpp#newcode...
> src/gpu/SkGpuDevice.cpp:1961: GrAssert(texture && texture->asRenderTarget());
> On 2012/08/28 15:02:31, robertphillips wrote:
> > Maybe a comment here as to why we know SkGpuDevice gets to take control of
the
> > lock?
> 
> Done.

Expand All Messages | Collapse All Messages