Issue 6498045: Fix ANGLE build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6498045: Fix ANGLE build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by EricB

Modified:
12 years, 2 months ago

Reviewers:
bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix ANGLE build Committed: https://code.google.com/p/skia/source/detail?r=5315

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	src/views/win/SkOSWindow_win.cpp	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2012/08/28 13:49:13, EricB wrote: Why does the GR_GL_CALL macro not work with the ANGLE ...

12 years, 2 months ago (2012-08-28 14:10:21 UTC) #2

robertphillips

GR_GL_CALL is in src\gpu\gl\GrGLUtil.h. If it is kosher for src\views\win\SkOSWindow_win.cpp to reach over and grab ...

12 years, 2 months ago (2012-08-28 14:49:11 UTC) #3

bsalomon

12 years, 2 months ago (2012-08-28 14:56:48 UTC) #4

Oh that does seem intrusive.

LGTM


On Tue, Aug 28, 2012 at 10:49 AM, <robertphillips@google.com> wrote:

> GR_GL_CALL is in src\gpu\gl\GrGLUtil.h. If it is kosher for
> src\views\win\SkOSWindow_win.**cpp to reach over and grab it then that
> would certainly work. r3856 (May 7th) moved GL_GL_CALL out of
> include/gpu/gl/GrGLConfig.h and into GrGLUtil.h, leaving the angle refs
> dangling.
>
>
http://codereview.appspot.com/**6498045/<http://codereview.appspot.com/6498045/>
>

Expand All Messages | Collapse All Messages