Issue 6497125: Added GPU resource cache stats printing to bench & removed some noise from inst counting information

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497125: Added GPU resource cache stats printing to bench & removed some noise from inst counting information (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by robertphillips

Modified:
12 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added while pursuing repeatTile_index8 bug.

Patch Set 2 : addressed code review issues #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	bench/benchmain.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM w/ a couple Qs https://codereview.appspot.com/6497125/diff/1/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.appspot.com/6497125/diff/1/bench/benchmain.cpp#newcode13 bench/benchmain.cpp:13: #include "GrConfig.h" Do we ...

12 years, 4 months ago (2012-09-12 20:57:36 UTC) #2

robertphillips

12 years, 4 months ago (2012-09-13 14:05:28 UTC) #3

Committed as r5519

https://codereview.appspot.com/6497125/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/6497125/diff/1/bench/benchmain.cpp#newcode13
bench/benchmain.cpp:13: #include "GrConfig.h"
On 2012/09/12 20:57:37, bsalomon wrote:
> Do we need this? We rarely directly include GrConfig.h (GrTypes.h if nothing
> else is necessary). (Same w/ SkConfig.h)

Done.

https://codereview.appspot.com/6497125/diff/1/bench/benchmain.cpp#newcode878
bench/benchmain.cpp:878: gRealGLHelper.cleanup();
On 2012/09/12 20:57:37, bsalomon wrote:
> Should we have a #if SK_ANGLE glAngleGLHelper.cleanup() #endif?

Done.

Expand All Messages | Collapse All Messages