Issue 6497114: Reduce SkMaskGamma cache thrashing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497114: Reduce SkMaskGamma cache thrashing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bungeman

Modified:
12 years, 1 month ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Reduce SkMaskGamma cache thrashing.

Patch Set 1 #

Patch Set 2 : Ensure linear maskGamma is not used. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -17 lines)			Patch
M	src/core/SkMaskGamma.h	View	1	8 chunks	+17 lines, -5 lines	0 comments	Download
M	src/core/SkMaskGamma.cpp	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1	8 chunks	+27 lines, -9 lines	0 comments	Download
M	src/core/SkScalerContext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

I'm open to suggestions on implementation here, but we need a means of having both ...

12 years, 1 month ago (2012-09-11 16:57:20 UTC) #1

reed1

lgtm are there unittests we can be writing to exercise any of this?

12 years, 1 month ago (2012-09-11 17:03:21 UTC) #2

bungeman

12 years, 1 month ago (2012-09-11 18:53:23 UTC) #3

For this particular issue there isn't much unit tests could do, but I'm fairly
sure this will change again when getting things to work with the GPU. I'll keep
it in mind.

Committed revisions 5492 and 5493.

Expand All Messages | Collapse All Messages