Issue 6497086: Add R-Tree bench.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497086: Add R-Tree bench. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rileya

Modified:
12 years, 3 months ago

Reviewers:
bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add R-Tree bench. Committed: https://code.google.com/p/skia/source/detail?r=5404

Patch Set 2 : Tidied up a bit. #

Patch Set 3 : Generalized classes to take BBoxHierarchies. #

Total comments: 8

Patch Set 4 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -0 lines)			Patch
	A	bench/RTreeBench.cpp	View	1 2 3	1 chunk	+213 lines, -0 lines	0 comments	Download
	M	gyp/bench.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rileya

There are a ton of parameters and possible permutations here, I only picked a small ...

12 years, 3 months ago (2012-09-05 15:57:31 UTC) #1

bsalomon

Maybe the 50, 500, 400, and 200 literals should be replaced by a computed fraction ...

12 years, 3 months ago (2012-09-05 17:01:06 UTC) #2

robertphillips

LGTM + nits https://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp File bench/RTreeBench.cpp (right): https://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp#newcode22 bench/RTreeBench.cpp:22: class BBoxBuildBench : public SkBenchmark { ...

12 years, 3 months ago (2012-09-05 17:12:32 UTC) #3

rileya

12 years, 3 months ago (2012-09-05 17:37:01 UTC) #4

On 2012/09/05 17:01:06, bsalomon wrote:
> Maybe the 50, 500, 400, and 200 literals should be replaced by a computed
> fraction of the GENERATE_EXTENTS. Otherwise, LGTM.

Fixed.

http://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp
File bench/RTreeBench.cpp (right):

http://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp#newcode22
bench/RTreeBench.cpp:22: class BBoxBuildBench : public SkBenchmark {
On 2012/09/05 17:12:32, robertphillips wrote:
> // Time how long it takes to build an rTree either bulk-loaded or not

Added.

http://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp#newcode26
bench/RTreeBench.cpp:26: : INHERITED(param)
On 2012/09/05 17:12:32, robertphillips wrote:
> init in order declared - some compiler whines about this

Fixed.

http://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp#newcode66
bench/RTreeBench.cpp:66: , fTree(tree)
On 2012/09/05 17:12:32, robertphillips wrote:
> order

Fixed.

http://codereview.appspot.com/6497086/diff/4002/bench/RTreeBench.cpp#newcode169
bench/RTreeBench.cpp:169: 
On 2012/09/05 17:12:32, robertphillips wrote:
> Could automatically add the query/build & _bulk name prefixes/suffixes.

Done.

Expand All Messages | Collapse All Messages