Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(396)

Issue 6497054: Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by jkleinert
Modified:
11 years, 7 months ago
Reviewers:
badouglas
CC:
badouglas
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline. BUG=745 Committed: https://code.google.com/p/skia/source/detail?r=5360

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M tools/skdiff_main.cpp View 1 2 6 chunks +34 lines, -3 lines 1 comment Download
M tools/tests/skdiff/test1/output-expected/index.html View 1 1 chunk +28 lines, -10 lines 0 comments Download

Messages

Total messages: 4
jkleinert
Hi Elliot, These are the changes for http://code.google.com/p/skia/issues/detail?id=745 based on your most recent comments. -Jan
11 years, 7 months ago (2012-08-29 21:01:15 UTC) #1
epoger
LGTM! That's a great help, Jan. Thanks! https://codereview.appspot.com/6497054/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6497054/diff/1/tools/skdiff_main.cpp#newcode1156 tools/skdiff_main.cpp:1156: outputStream.writeText("<html>\n<head>\n"); IMHO: ...
11 years, 7 months ago (2012-08-30 18:53:13 UTC) #2
jkleinert
Done here and in the other similar section I added after it. I agree it's ...
11 years, 7 months ago (2012-08-30 21:44:18 UTC) #3
badouglas
11 years, 7 months ago (2012-08-30 22:07:51 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b