Issue 6497054: Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497054: Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by jkleinert

Modified:
12 years, 3 months ago

Reviewers:
badouglas

CC:
badouglas

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adding checkboxes to skdiff output so a user can select a subset of images to rebaseline. BUG=745 Committed: https://code.google.com/p/skia/source/detail?r=5360

Patch Set 3 : #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -13 lines)			Patch
	M	tools/skdiff_main.cpp	View	1 2	6 chunks	+34 lines, -3 lines	1 comment	Download
	M	tools/tests/skdiff/test1/output-expected/index.html	View	1	1 chunk	+28 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jkleinert

Hi Elliot, These are the changes for http://code.google.com/p/skia/issues/detail?id=745 based on your most recent comments. -Jan

12 years, 3 months ago (2012-08-29 21:01:15 UTC) #1

epoger

LGTM! That's a great help, Jan. Thanks! https://codereview.appspot.com/6497054/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6497054/diff/1/tools/skdiff_main.cpp#newcode1156 tools/skdiff_main.cpp:1156: outputStream.writeText("<html>\n<head>\n"); IMHO: ...

12 years, 3 months ago (2012-08-30 18:53:13 UTC) #2

jkleinert

Done here and in the other similar section I added after it. I agree it's ...

12 years, 3 months ago (2012-08-30 21:44:18 UTC) #3

badouglas

12 years, 3 months ago (2012-08-30 22:07:51 UTC) #4

test1

http://codereview.appspot.com/6497054/diff/7001/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/6497054/diff/7001/tools/skdiff_main.cpp#newcode990
tools/skdiff_main.cpp:990: 
/*
test
*/

Expand All Messages | Collapse All Messages