Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1531)

Issue 6497044: code review 6497044: net: delete unused IP-level socket option helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by mikio
Modified:
10 years, 2 months ago
Reviewers:
CC:
rsc, dfc, bradfitz, gobot, golang-dev
Visibility:
Public.

Description

net: delete unused IP-level socket option helpers

Patch Set 1 : diff -r 6836919e6ff1 https://code.google.com/p/go #

Patch Set 2 : diff -r dbcfb4459ab8 https://code.google.com/p/go #

Patch Set 3 : diff -r dbcfb4459ab8 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -832 lines) Patch
M src/pkg/net/multicast_posix_test.go View 1 3 chunks +0 lines, -65 lines 0 comments Download
M src/pkg/net/sockoptip_bsd.go View 1 2 chunks +9 lines, -29 lines 0 comments Download
R src/pkg/net/sockoptip_darwin.go View 1 chunk +0 lines, -90 lines 0 comments Download
R src/pkg/net/sockoptip_freebsd.go View 1 chunk +0 lines, -92 lines 0 comments Download
M src/pkg/net/sockoptip_linux.go View 1 4 chunks +0 lines, -101 lines 0 comments Download
R src/pkg/net/sockoptip_netbsd.go View 1 chunk +0 lines, -90 lines 0 comments Download
R src/pkg/net/sockoptip_openbsd.go View 1 chunk +0 lines, -90 lines 0 comments Download
M src/pkg/net/sockoptip_posix.go View 1 5 chunks +6 lines, -152 lines 0 comments Download
M src/pkg/net/sockoptip_windows.go View 1 1 chunk +6 lines, -55 lines 0 comments Download
M src/pkg/net/udpsock_posix.go View 2 chunks +0 lines, -16 lines 0 comments Download
M src/pkg/net/unicast_posix_test.go View 1 3 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 11
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 3 months ago (2012-08-28 15:50:25 UTC) #1
bradfitz
That's a lot of deleted lines. Normally I'd quickly approve deleting a helper function or ...
10 years, 3 months ago (2012-08-28 15:59:54 UTC) #2
dfc
That's a lot of deleted lines. > > Normally I'd quickly approve deleting a helper ...
10 years, 3 months ago (2012-08-28 23:35:36 UTC) #3
mikio
On 2012/08/28 23:35:36, dfc wrote: > I think most of the logic is being relocated ...
10 years, 3 months ago (2012-08-29 03:36:38 UTC) #4
gobot
R=rsc (assigned by rsc)
10 years, 3 months ago (2012-09-01 14:40:45 UTC) #5
dfc
On 2012/09/01 14:40:45, gobot wrote: > R=rsc (assigned by rsc) I'm concerned that the version ...
10 years, 2 months ago (2012-09-03 11:00:54 UTC) #6
mikio
On Mon, Sep 3, 2012 at 8:00 PM, <dave@cheney.net> wrote: > I'm concerned that the ...
10 years, 2 months ago (2012-09-03 11:51:28 UTC) #7
dfc
> My guess is that both fd.incref/decref are just for closing multiple socket > read/writers, ...
10 years, 2 months ago (2012-09-05 10:31:46 UTC) #8
dfc
LGTM once http://codereview.appspot.com/6482044/ goes in.
10 years, 2 months ago (2012-09-05 10:40:30 UTC) #9
rsc
LGTM I'm surprised we had all this dead code lying around but...
10 years, 2 months ago (2012-09-10 16:04:58 UTC) #10
mikio
10 years, 2 months ago (2012-09-10 23:56:35 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=872a70417273 ***

net: delete unused IP-level socket option helpers

R=rsc, dave
CC=bradfitz, gobot, golang-dev
http://codereview.appspot.com/6497044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b