Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)

Issue 6496109: Add -logPerIter, -timers, and -min to bench_pictures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Leon
Modified:
12 years, 3 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add -logPerIter, -timers, and -min to bench_pictures. Additional changes: Add instance count to bench_pictures. Remove various PictureBenchmark subclasses which did not do anything besides have a different PictureRenderer. BUG=https://code.google.com/p/skia/issues/detail?id=856 Committed: https://code.google.com/p/skia/source/detail?r=5496

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -189 lines) Patch
M tools/PictureBenchmark.h View 3 chunks +30 lines, -120 lines 0 comments Download
M tools/PictureBenchmark.cpp View 3 chunks +42 lines, -30 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 2 12 chunks +92 lines, -39 lines 0 comments Download

Messages

Total messages: 5
Leon
12 years, 3 months ago (2012-09-11 17:52:26 UTC) #1
EricB
I think I misunderstood our conversation about the command-line options. I believe that bench is ...
12 years, 3 months ago (2012-09-11 18:17:21 UTC) #2
Leon
On 2012/09/11 18:17:21, EricB wrote: > I think I misunderstood our conversation about the command-line ...
12 years, 3 months ago (2012-09-11 18:22:11 UTC) #3
EricB
On 2012/09/11 18:22:11, scroggo-work wrote: > On 2012/09/11 18:17:21, EricB wrote: > > I think ...
12 years, 3 months ago (2012-09-11 18:36:47 UTC) #4
Leon
12 years, 3 months ago (2012-09-11 19:04:09 UTC) #5
Changed it back to using '--'
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b