Issue 6496106: code review 6496106: cmd/6g, cmd/8g: clean up unnecessary switch code in com...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496106: code review 6496106: cmd/6g, cmd/8g: clean up unnecessary switch code in com... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by nigeltao

Modified:
12 years, 6 months ago

Reviewers:

CC:
remyoudompheng, rsc, golang-dev

Visibility:
Public.

Description

cmd/6g, cmd/8g: clean up unnecessary switch code in componentgen. Code higher up in the function already catches these cases.

Patch Set 1 #

Patch Set 2 : diff -r 46e193d130ce https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 46e193d130ce https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ffe134f40269 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	src/cmd/6g/cgen.c	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download
	M	src/cmd/8g/cgen.c	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2012-09-11 10:04:15 UTC) #1

nigeltao

12 years, 6 months ago (2012-09-12 11:47:13 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cb954a5350e9 ***

cmd/6g, cmd/8g: clean up unnecessary switch code in componentgen.
Code higher up in the function already catches these cases.

R=remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6496106

Expand All Messages | Collapse All Messages