Issue 6496084: Tolerate older twisted versions in openstack provider

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496084: Tolerate older twisted versions in openstack provider

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gz

Modified:
13 years, 5 months ago

Reviewers:
jimbaker, mp+122849

Visibility:
Public.

Description

Tolerate older twisted versions in openstack provider The juju ppa includes newer versions of txaws and txzookeeper, but uses the system twisted version. This means it ftbfs on natty and oneiric, which doesn't matter much as most devs should be using something newer anyway, but is not hard to fix. This branch uses some existing compat code and adds a conditional import, which is enough to make happiness. https://code.launchpad.net/~gz/juju/old_twisted_1029070/+merge/122849 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -13 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/openstack/client.py	View	4 chunks	+10 lines, -7 lines	0 comments	Download
M	juju/providers/openstack/provider.py	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	juju/providers/openstack/tests/test_client.py	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

+1, this compatibility fix LGTM

Expand All Messages | Collapse All Messages