Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1063)

Issue 6496083: code review 6496083: go.crypto/salsa20: add package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by agl1
Modified:
10 years, 3 months ago
Reviewers:
CC:
golang-dev, dchest
Visibility:
Public.

Description

go.crypto/salsa20: add package. Package salsa20 implements the Salsa20 stream cipher as specified in http://cr.yp.to/snuffle/spec.pdf. (Reference implementation by dchest.)

Patch Set 1 #

Patch Set 2 : diff -r c349712b1885 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r c349712b1885 https://code.google.com/p/go.crypto #

Total comments: 8

Patch Set 4 : diff -r c349712b1885 https://code.google.com/p/go.crypto #

Total comments: 3

Patch Set 5 : diff -r d7d342670efa https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1489 lines, -0 lines) Patch
A salsa20/salsa/hsalsa20.go View 1 1 chunk +144 lines, -0 lines 0 comments Download
A salsa20/salsa/salsa2020_amd64.s View 1 1 chunk +900 lines, -0 lines 0 comments Download
A salsa20/salsa/salsa20_amd64.go View 1 1 chunk +18 lines, -0 lines 0 comments Download
A salsa20/salsa/salsa20_ref.go View 1 2 3 4 1 chunk +234 lines, -0 lines 0 comments Download
A salsa20/salsa20.go View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A salsa20/salsa20_test.go View 1 1 chunk +139 lines, -0 lines 0 comments Download

Messages

Total messages: 5
agl1
Hello golang-dev@googlegroups.com (cc: dchest@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 3 months ago (2012-09-04 17:06:27 UTC) #1
dchest
Some quick comments (mostly typos) before the proper review. https://codereview.appspot.com/6496083/diff/1002/salsa20/salsa/salsa20_ref.go File salsa20/salsa/salsa20_ref.go (right): https://codereview.appspot.com/6496083/diff/1002/salsa20/salsa/salsa20_ref.go#newcode12 salsa20/salsa/salsa20_ref.go:12: ...
10 years, 3 months ago (2012-09-04 19:36:03 UTC) #2
agl1
All good points, thanks! https://codereview.appspot.com/6496083/diff/1002/salsa20/salsa/salsa20_ref.go File salsa20/salsa/salsa20_ref.go (right): https://codereview.appspot.com/6496083/diff/1002/salsa20/salsa/salsa20_ref.go#newcode12 salsa20/salsa/salsa20_ref.go:12: // and 16-byte constant c, ...
10 years, 3 months ago (2012-09-04 21:34:19 UTC) #3
dchest
LGTM https://codereview.appspot.com/6496083/diff/1003/salsa20/salsa/salsa20_ref.go File salsa20/salsa/salsa20_ref.go (right): https://codereview.appspot.com/6496083/diff/1003/salsa20/salsa/salsa20_ref.go#newcode214 salsa20/salsa/salsa20_ref.go:214: core(&block, &counterCopy, key, &sigma) &Sigma (it's exported. Otherwise ...
10 years, 3 months ago (2012-09-06 16:28:15 UTC) #4
agl1
10 years, 3 months ago (2012-09-08 14:42:09 UTC) #5
*** Submitted as
http://code.google.com/p/go/source/detail?r=05426f7f4922&repo=crypto ***

go.crypto/salsa20: add package.

Package salsa20 implements the Salsa20 stream cipher as specified in
http://cr.yp.to/snuffle/spec.pdf.

(Reference implementation by dchest.)

R=golang-dev, dchest
CC=golang-dev
http://codereview.appspot.com/6496083

http://codereview.appspot.com/6496083/diff/1003/salsa20/salsa/salsa20_ref.go
File salsa20/salsa/salsa20_ref.go (right):

http://codereview.appspot.com/6496083/diff/1003/salsa20/salsa/salsa20_ref.go#...
salsa20/salsa/salsa20_ref.go:214: core(&block, &counterCopy, key, &sigma)
On 2012/09/06 16:28:15, dchest wrote:
> &Sigma
> 
> (it's exported. Otherwise this won't compile).

Good point, thanks! I'll test this in a 386 build before landing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b