Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1346)

Issue 6496066: Refactor vala code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Daiki Ueno
Modified:
11 years, 7 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Cleanup the vala code of gtk3 panel and tool by: - using config.vapi - omitting unnecessary "using X" Also localize ibus tool and make the argument handling better. BUG=none

Patch Set 1 #

Total comments: 7

Patch Set 2 : use GLib.Intl instead of Intl; remove useless "using" #

Patch Set 3 : fix make distcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -124 lines) Patch
M bindings/vala/Makefile.am View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A bindings/vala/config.vapi View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/Makefile.am View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M tools/main.vala View 1 5 chunks +91 lines, -53 lines 0 comments Download
M ui/gtk3/Makefile.am View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ui/gtk3/application.vala View 1 1 chunk +3 lines, -9 lines 0 comments Download
M ui/gtk3/candidatearea.vala View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gtk3/candidatepanel.vala View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gtk3/handle.vala View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gtk3/iconwidget.vala View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gtk3/keybindingmanager.vala View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gtk3/panel.vala View 1 2 6 chunks +5 lines, -13 lines 0 comments Download
M ui/gtk3/pango.vala View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gtk3/property.vala View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gtk3/separator.vala View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gtk3/switcher.vala View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4
Daiki Ueno
11 years, 8 months ago (2012-08-31 09:12:24 UTC) #1
Peng
https://codereview.appspot.com/6496066/diff/1/tools/Makefile.am File tools/Makefile.am (right): https://codereview.appspot.com/6496066/diff/1/tools/Makefile.am#newcode33 tools/Makefile.am:33: AM_CPPFLAGS = -include $(CONFIG_HEADER) Is it necessary? https://codereview.appspot.com/6496066/diff/1/tools/main.vala File ...
11 years, 8 months ago (2012-08-31 11:03:03 UTC) #2
Daiki Ueno
https://codereview.appspot.com/6496066/diff/1/tools/Makefile.am File tools/Makefile.am (right): https://codereview.appspot.com/6496066/diff/1/tools/Makefile.am#newcode33 tools/Makefile.am:33: AM_CPPFLAGS = -include $(CONFIG_HEADER) On 2012/08/31 11:03:03, Peng wrote: ...
11 years, 8 months ago (2012-08-31 21:44:28 UTC) #3
Peng
11 years, 7 months ago (2012-09-03 03:39:41 UTC) #4
Lgtm

https://codereview.appspot.com/6496066/diff/1/tools/main.vala
File tools/main.vala (right):

https://codereview.appspot.com/6496066/diff/1/tools/main.vala#newcode23
tools/main.vala:23: using IBus;
I see. Seems all using could be removed
On 2012/08/31 21:44:29, Daiki Ueno wrote:
> On 2012/08/31 11:03:03, Peng wrote:
> > Do not need using config here? And other vala files?
> 
> No, vala's using is just to allow programmers to omit the namespace when
access.
>  If you call all the IBus.* symbols like IBus.foo, you won't need "using
IBus":
> https://live.gnome.org/Vala/Tutorial/#Namespaces
> 
> Also, "using GLib" is vala's default behavior and can be omitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b