Fix a Ref count bug in SkFontHost_win_dw.cpp

We don't need to add a ref to SkTypeface here(Line 459), because FindByProcAndRef already do it.
The ref count should be managed by SkTypefaceCache.
(The same way as SkFontHost_win.cpp :  SkCreateTypefaceFromLOGFONT)

[Jare, 2012-09-16 09:32:17]

http://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (left):

http://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp#...
src/ports/SkFontHost_win_dw.cpp:460: face->ref();
We don't need to add a ref to face here, because FindByProcAndRef had already do
it.
The ref should be managed by SkTypefaceCache

[bungeman, 2012-09-17 14:12:02]

This lgtm with one style nit. It doesn't look like you can commit, so I'll get
this in.

https://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (left):

https://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:460: face->ref();
On 2012/09/16 09:32:18, Jare wrote:
> We don't need to add a ref to face here

You're right, good catch. This used to be a call to FindByProc, but that was
changed to FindByProcAndRef while the DirectWrite font host was being developed.
The call got updated but not the logic.

https://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (right):

https://codereview.appspot.com/6495133/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:459: if (!face) {
To match Skia convention this needs to be 'if (NULL == face) {'.

[bungeman, 2012-09-17 14:29:32]

Committed revision 5568.

Please review commit and, if the commit is acceptable, close this issue.

[Jare, 2012-09-18 11:12:38]

On 2012/09/17 14:29:32, bungeman wrote:

OK, Thanks!