Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 6495117: Add IBusProperty.icon_text for the short label. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by fujiwara
Modified:
13 years, 4 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Add IBusProperty.symbol for the short label. IBusProperty.label had been shared between the panel menu label and language-bar button label so the label is too short against the panel menu. Now we redefines IBusProperty.label as the long label and the new IBusProperty.symbol is defined as the short label for the language-bar and the panel status icon. TEST=Manually

Patch Set 1 #

Patch Set 2 : Fixed a typo. #

Patch Set 3 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -80 lines) Patch
M ibus/property.py View 1 2 6 chunks +13 lines, -1 line 0 comments Download
M src/ibusproperty.h View 1 2 7 chunks +101 lines, -68 lines 0 comments Download
M src/ibusproperty.c View 1 2 14 chunks +90 lines, -11 lines 0 comments Download

Messages

Total messages: 4
fujiwara
13 years, 4 months ago (2012-09-12 09:19:52 UTC) #1
Peng
On 2012/09/12 09:19:52, fujiwara wrote: Could we use symbol for it? It is the same ...
13 years, 4 months ago (2012-09-12 17:36:55 UTC) #2
fujiwara
On 2012/09/12 17:36:55, Peng wrote: > On 2012/09/12 09:19:52, fujiwara wrote: > > Could we ...
13 years, 4 months ago (2012-09-13 02:40:11 UTC) #3
Peng
13 years, 4 months ago (2012-09-14 01:07:51 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b