Issue 6495102: setting .length can delete non-configurable properties

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6495102: setting .length can delete non-configurable properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by felix8a

Modified:
13 years, 7 months ago

Reviewers:
MarkM, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Setting a.length can delete non-configurable properties of a. This is fixed in current versions of firefox and safari, but Chrome Canary still has this bug. So this adds a test for that in repairES5.js. This is similar to the pop() ignores frozenness problem, but Chrome passes the pop test and fails this test.

Patch Set 1 #

Total comments: 1

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/com/google/caja/ses/repairES5.js	View		2 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

MarkM

https://codereview.appspot.com/6495102/diff/1/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): https://codereview.appspot.com/6495102/diff/1/src/com/google/caja/ses/repairES5.js#newcode2959 src/com/google/caja/ses/repairES5.js:2959: tests: [] // TODO(erights): Add to test262 There are ...

13 years, 7 months ago (2012-09-06 22:06:33 UTC) #3

felix8a

13 years, 7 months ago (2012-09-06 22:19:46 UTC) #5

chrome issue https://code.google.com/p/chromium/issues/detail?id=146910

Expand All Messages | Collapse All Messages